Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networking: Disable private IPs by default. #1732

Merged
merged 1 commit into from
Aug 1, 2023
Merged

networking: Disable private IPs by default. #1732

merged 1 commit into from
Aug 1, 2023

Conversation

shamil-gadelshin
Copy link
Member

@shamil-gadelshin shamil-gadelshin commented Aug 1, 2023 •
edited by nazar-pc
Loading

This PR changes --disable-private-ips flag to --enable-private-ips for subspace-node (with dsn- prefix), subspace-farmer and subspace-bootstrap-node applications. This change disable private IPs by the default.

cc @DaMandal0rian

Code contributor checklist:

@shamil-gadelshin shamil-gadelshin added the networking Subspace networking (DSN) label Aug 1, 2023
@shamil-gadelshin shamil-gadelshin self-assigned this Aug 1, 2023
@shamil-gadelshin shamil-gadelshin merged commit 7944f1a into main Aug 1, 2023
@shamil-gadelshin shamil-gadelshin deleted the make-private-ips-disabled-by-default branch August 1, 2023 11:07
ParthDesai added a commit to autonomys/subspace-pulsar-sdk that referenced this pull request Aug 5, 2023
@ParthDesai
import autonomys/subspace#1703 autonomys/subspace#1719 autonomys/subs…
3b5b8bb 
…pace#1721 autonomys/subspace#1716 autonomys/subspace#1722 autonomys/subspace#1732 autonomys/subspace#1733 autonomys/subspace#1704
ParthDesai added a commit to autonomys/subspace-pulsar-sdk that referenced this pull request Aug 5, 2023
@ParthDesai
import autonomys/subspace#1703 autonomys/subspace#1719 autonomys/subs…
b90e07b 
…pace#1721 autonomys/subspace#1716 autonomys/subspace#1722 autonomys/subspace#1732 autonomys/subspace#1733 autonomys/subspace#1704 autonomys/subspace#1710 subspace#1737 autonomys/subspace#1736
ParthDesai added a commit to autonomys/subspace-pulsar-sdk that referenced this pull request Aug 15, 2023
@ParthDesai
import autonomys/subspace#1703 autonomys/subspace#1719 autonomys/subs…
b38f4cb 
…pace#1721 autonomys/subspace#1716 autonomys/subspace#1722 autonomys/subspace#1732 autonomys/subspace#1733 autonomys/subspace#1704 autonomys/subspace#1710 subspace#1737 autonomys/subspace#1736
ParthDesai added a commit to autonomys/subspace-pulsar-sdk that referenced this pull request Aug 15, 2023
@ParthDesai
import autonomys/subspace#1703 autonomys/subspace#1719 autonomys/subs…
dab0330 
…pace#1721 autonomys/subspace#1716 autonomys/subspace#1722 autonomys/subspace#1732 autonomys/subspace#1733 autonomys/subspace#1704 autonomys/subspace#1710 subspace#1737 autonomys/subspace#1736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazar-pc nazar-pc nazar-pc approved these changes

@NingLin-P NingLin-P Awaiting requested review from NingLin-P NingLin-P is a code owner

@rg3l3dr rg3l3dr Awaiting requested review from rg3l3dr rg3l3dr is a code owner

@DaMandal0rian DaMandal0rian Awaiting requested review from DaMandal0rian

Assignees

@shamil-gadelshin shamil-gadelshin

Labels
networking Subspace networking (DSN)
Projects
Subspace core (node, farmer, etc.)
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shamil-gadelshin @nazar-pc